-
Notifications
You must be signed in to change notification settings - Fork 5
feat: update conn wizard when kube config(s) are updated (#23558) #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
778cfa0 to
c6f7184
Compare
47edf9b to
b76f344
Compare
180cdb6 to
0f82978
Compare
|
@vrubezhny, @azatsarynnyy: please review. To test it:
ps. KUBECONFIG env variable looks as follows (on MacOS, set it in ~/.zprofile): |
0f82978 to
9fefbf5
Compare
|
Token doesn't get renewed from Kube config when it's changed while you were at Steps to reproduce:
|
9fefbf5 to
b663469
Compare
|
@vrubezhny: thx for findining this! Fixed it. I now start watching kube config files when the wizard page is shown and stop when it is hidden. |
vrubezhny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Cluster wizard page: - cluster/token are updated if kube config or any file listed in `KUBECONFIG` env var is changed - "Next"-button is enabled/disabled as you provide cluster & token Signed-off-by: Andre Dietisheim <[email protected]> Assisted by: gemini-cli Assisted by: cursor Assisted by: qwen-code
b663469 to
ae6be48
Compare
Signed-off-by: Victor Rubezhny <[email protected]>
ae6be48 to
a46917a
Compare
|
added a test and printing of the full stacktrace if a test fails (suggested by @vrubezhny) |
fixes eclipse-che/che#23558
out of the currently 2300 added lines, 1600 are tests 😄